Fix PointTransformerConv aggregation from mean to sum
#5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message in PointTransformerConv is already softmax, which sum to one. The aggregation should be `add` rather `mean`.
Codecov Report
@@ Coverage Diff @@
## master #5332 +/- ##
==========================================
- Coverage 83.37% 83.26% -0.12%
==========================================
Files 338 338
Lines 18637 18637
==========================================
- Hits 15539 15518 -21
- Misses 3098 3119 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Padarn
reviewed
Sep 2, 2022
rusty1s
changed the title
PointTransformerConv aggregation from mean to sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message in PointTransformerConv is already softmax, which sum to one. The aggregation should be
addrathermean.