Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sampler argument in LightningDataModule #5456

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Sep 16, 2022

No description provided.

@github-actions github-actions bot added the data label Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #5456 (565f8ba) into master (67b8324) will decrease coverage by 2.08%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##           master    #5456      +/-   ##
==========================================
- Coverage   85.42%   83.34%   -2.09%     
==========================================
  Files         348      348              
  Lines       18913    18935      +22     
==========================================
- Hits        16157    15781     -376     
- Misses       2756     3154     +398     
Impacted Files Coverage Δ
torch_geometric/data/lightning_datamodule.py 43.14% <5.26%> (-5.98%) ⬇️
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/profile/profile.py 37.89% <0.00%> (-26.32%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/nn/pool/asap.py 92.10% <0.00%> (-6.58%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/resolver.py 88.88% <0.00%> (-5.56%) ⬇️
torch_geometric/sampler/neighbor_sampler.py 92.90% <0.00%> (-5.17%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit ec7400e into master Sep 16, 2022
@rusty1s rusty1s deleted the sampler_support branch September 16, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant