Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow . in ParameterDict key names #5494

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Allow . in ParameterDict key names #5494

merged 4 commits into from
Sep 21, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Sep 21, 2022

No description provided.

@rusty1s rusty1s self-assigned this Sep 21, 2022
@rusty1s rusty1s changed the title Allow . in in ParameterDict key names Allow . in ParameterDict key names Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #5494 (6801ffa) into master (d3f35cb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5494      +/-   ##
==========================================
+ Coverage   83.30%   83.32%   +0.02%     
==========================================
  Files         350      351       +1     
  Lines       19049    19075      +26     
==========================================
+ Hits        15868    15894      +26     
  Misses       3181     3181              
Impacted Files Coverage Δ
torch_geometric/nn/conv/hgt_conv.py 97.00% <100.00%> (+0.06%) ⬆️
torch_geometric/nn/module_dict.py 100.00% <100.00%> (ø)
torch_geometric/nn/parameter_dict.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 5d00ccf into master Sep 21, 2022
@rusty1s rusty1s deleted the parameter_dict branch September 21, 2022 14:17
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
* parameter dict

* changelog

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant