Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] DenseSAGEConv and DenseGCNConv #5664

Merged
merged 13 commits into from
Oct 13, 2022
Merged

[Type Hints] DenseSAGEConv and DenseGCNConv #5664

merged 13 commits into from
Oct 13, 2022

Conversation

sachinsharma9780
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

Merging #5664 (c1cb37b) into master (75bcddd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c1cb37b differs from pull request most recent head 5ac1b73. Consider uploading reports for the commit 5ac1b73 to get more accurate results

@@           Coverage Diff           @@
##           master    #5664   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         349      349           
  Lines       19238    19241    +3     
=======================================
+ Hits        16135    16138    +3     
  Misses       3103     3103
Impacted Files Coverage Δ
torch_geometric/nn/dense/dense_gcn_conv.py 100.00% <100.00%> (ø)
torch_geometric/nn/dense/dense_sage_conv.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/node2vec.py 97.36% <0.00%> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title Type Hints dense_sage_conv.py [Type Hints] DenseSAGEConv Oct 12, 2022
@sachinsharma9780 sachinsharma9780 changed the title [Type Hints] DenseSAGEConv [Type Hints] DenseSAGEConv and 'DenseGCNConv' Oct 12, 2022
@sachinsharma9780 sachinsharma9780 changed the title [Type Hints] DenseSAGEConv and 'DenseGCNConv' [Type Hints] DenseSAGEConv and DenseGCNConv Oct 12, 2022
@rusty1s rusty1s mentioned this pull request Oct 13, 2022
Closed
rusty1s
rusty1s approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 06:56
@rusty1s rusty1s merged commit 03e8414 into pyg-team:master Oct 13, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@sachinsharma9780 @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] DenseSAGEConv and DenseGCNConv (pyg-team#5664)
a368c44 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@sachinsharma9780 sachinsharma9780

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachinsharma9780 @rusty1s