Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeHints] Node2Vec #5669

Merged
merged 8 commits into from
Oct 13, 2022
Merged

[TypeHints] Node2Vec #5669

merged 8 commits into from
Oct 13, 2022

Conversation

sebastian-montero
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

Merging #5669 (a6cd891) into master (bdd11e3) will increase coverage by 0.00%.
The diff coverage is 92.85%.

❗ Current head a6cd891 differs from pull request most recent head 1ef9b69. Consider uploading reports for the commit 1ef9b69 to get more accurate results

@@           Coverage Diff           @@
##           master    #5669   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         349      349           
  Lines       19235    19236    +1     
=======================================
+ Hits        16132    16133    +1     
  Misses       3103     3103
Impacted Files Coverage Δ
torch_geometric/nn/models/node2vec.py 97.46% <92.85%> (+0.09%) ⬆️
torch_geometric/transforms/to_dense.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s mentioned this pull request Oct 13, 2022
Closed
rusty1s
rusty1s approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TorchScript Node2Vec - cool :)

@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 06:47
@rusty1s rusty1s merged commit 75bcddd into pyg-team:master Oct 13, 2022
@sebastian-montero sebastian-montero deleted the type_hints/Node2Vec branch October 13, 2022 07:22
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@sebastian-montero @rusty1s @JakubPietrakIntel
[TypeHints] Node2Vec (pyg-team#5669)
d91a77e 
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdisonLeeeee EdisonLeeeee EdisonLeeeee left review comments

@rusty1s rusty1s rusty1s approved these changes

Assignees

@sebastian-montero sebastian-montero

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastian-montero @rusty1s @EdisonLeeeee