Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] utils.to_dense_adj and utils.get_laplacian #5682

Merged
merged 10 commits into from
Oct 14, 2022
Merged

[Type Hints] utils.to_dense_adj and utils.get_laplacian #5682

merged 10 commits into from
Oct 14, 2022

Conversation

LukeLIN-web
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #5682 (d0eb8d9) into master (145440d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d0eb8d9 differs from pull request most recent head 28bf4f1. Consider uploading reports for the commit 28bf4f1 to get more accurate results

@@           Coverage Diff           @@
##           master    #5682   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         349      349           
  Lines       19237    19238    +1     
=======================================
+ Hits        16121    16122    +1     
  Misses       3116     3116
Impacted Files Coverage Δ
torch_geometric/utils/get_laplacian.py 100.00% <100.00%> (ø)
torch_geometric/utils/to_dense_adj.py 85.29% <100.00%> (+0.91%) ⬆️
torch_geometric/utils/sparse.py 100.00% <0.00%> (ø)
torch_geometric/nn/norm/instance_norm.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title [Type Hints] utils.to_dense_adj and utils.get_laplacian [Type Hints] utils.to_dense_adj and utils.get_laplacian Oct 13, 2022
rusty1s
rusty1s approved these changes Oct 13, 2022
View reviewed changes
torch_geometric/utils/get_laplacian.py Outdated Show resolved Hide resolved
torch_geometric/utils/get_laplacian.py Outdated Show resolved Hide resolved
@rusty1s rusty1s mentioned this pull request Oct 13, 2022
Closed
@rusty1s rusty1s enabled auto-merge (squash) October 14, 2022 08:00
@rusty1s rusty1s merged commit ee0bec9 into pyg-team:master Oct 14, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@LukeLIN-web @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] utils.to_dense_adj and utils.get_laplacian (pyg-team…
651a619 
…#5682)

Co-authored-by: juyi.lin <juyi.lin@kaust.edu.sa>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@LukeLIN-web LukeLIN-web

Labels
0 - Priority P0 type hints utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeLIN-web @rusty1s