Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.max_pool_x #5687

Merged
merged 10 commits into from
Oct 14, 2022
Merged

[Type Hints] nn.max_pool_x #5687

merged 10 commits into from
Oct 14, 2022

Conversation

akash-vartak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #5687 (c36f60b) into master (ee0bec9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c36f60b differs from pull request most recent head c8bc3d6. Consider uploading reports for the commit c8bc3d6 to get more accurate results

@@            Coverage Diff             @@
##           master    #5687      +/-   ##
==========================================
- Coverage   83.80%   83.80%   -0.01%     
==========================================
  Files         349      349              
  Lines       19242    19238       -4     
==========================================
- Hits        16126    16122       -4     
  Misses       3116     3116
Impacted Files Coverage Δ
torch_geometric/nn/pool/max_pool.py 100.00% <100.00%> (ø)
torch_geometric/utils/to_dense_adj.py 84.37% <0.00%> (-1.34%) ⬇️
torch_geometric/utils/get_laplacian.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s enabled auto-merge (squash) October 14, 2022 08:05
@rusty1s rusty1s mentioned this pull request Oct 14, 2022
Closed
@rusty1s rusty1s merged commit e4b8c33 into pyg-team:master Oct 14, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@akash-vartak @rusty1s
@pre-commit-ci @JakubPietrakIntel
[Type Hints] nn.max_pool_x (pyg-team#5687)
fa4b069 
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@akash-vartak akash-vartak

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash-vartak @rusty1s