[Type Hints] nn.GNNExplainer
#5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5716 +/- ##
=========================================
Coverage ? 83.97%
=========================================
Files ? 349
Lines ? 19407
Branches ? 0
=========================================
Hits ? 16297
Misses ? 3110
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
reviewed
Oct 17, 2022
rusty1s
reviewed
Oct 18, 2022
|
Hi @rusty1s, I already did. I added type hints to all methods in the class Am I missing something? |
|
Ah, sorry. Overlooked that single file, my bad. |
No problem! I'll resolve the Changelog conflicts and this should be ready to merge. |
rusty1s
approved these changes
Oct 19, 2022
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
@rusty1s Please note that I am using `torch.jit.export()` instead of `torch.jit.script()` for the tests. Can you please confirm if this is ok? Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rusty1s Please note that I am using
torch.jit.export()instead oftorch.jit.script()for the tests. Can you please confirm if this is ok?