Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: VirtualNode mistakenly treats node features as edge features #5819

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Oct 25, 2022

Fixes #5818

@rusty1s rusty1s self-assigned this Oct 25, 2022
@rusty1s rusty1s changed the title Fix: VirtualNode mistakenly treats node-features as edge features Fix: VirtualNode mistakenly treats node features as edge features Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #5819 (d3b278a) into master (344b143) will decrease coverage by 1.88%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #5819      +/-   ##
==========================================
- Coverage   85.85%   83.97%   -1.89%     
==========================================
  Files         349      349              
  Lines       19439    19439              
==========================================
- Hits        16689    16323     -366     
- Misses       2750     3116     +366     
Impacted Files Coverage Δ
torch_geometric/transforms/virtual_node.py 93.47% <80.00%> (-6.53%) ⬇️
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.90% <0.00%> (-52.76%) ⬇️
torch_geometric/profile/profile.py 37.89% <0.00%> (-26.32%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/pool/asap.py 92.10% <0.00%> (-7.90%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/resolver.py 88.88% <0.00%> (-5.56%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 392948d into master Oct 25, 2022
@rusty1s rusty1s deleted the fix_virtual_node branch October 25, 2022 06:54
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a virtual node expands mini-batched Data's batch attribute incorrectly
1 participant