Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightningDataModule: Add support for passing custom sampler #5820

Merged
merged 10 commits into from
Oct 25, 2022

Conversation

wsad1
Copy link
Member

@wsad1 wsad1 commented Oct 25, 2022

Currently the LightningNodeData and LightningLinkData sets neighbor_sampler to NeighborSampler. With this PR the user can specify which sampler to use. This is useful if the user wants to use a custom sampler, like some sort of remote sampler.

@wsad1 wsad1 requested a review from rusty1s October 25, 2022 07:32
@github-actions github-actions bot added the data label Oct 25, 2022
@wsad1 wsad1 self-assigned this Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #5820 (98754ab) into master (392948d) will increase coverage by 0.12%.
The diff coverage is 75.00%.

❗ Current head 98754ab differs from pull request most recent head 146d337. Consider uploading reports for the commit 146d337 to get more accurate results

@@            Coverage Diff             @@
##           master    #5820      +/-   ##
==========================================
+ Coverage   83.97%   84.09%   +0.12%     
==========================================
  Files         349      349              
  Lines       19439    19451      +12     
==========================================
+ Hits        16323    16358      +35     
+ Misses       3116     3093      -23     
Impacted Files Coverage Δ
torch_geometric/data/lightning_datamodule.py 56.50% <75.00%> (+13.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title LightningDataModule: Add support for passing custom neighbor_sampler. LightningDataModule: Add support for passing custom sampler Oct 25, 2022
@rusty1s rusty1s merged commit 4398de0 into master Oct 25, 2022
@rusty1s rusty1s deleted the lightning_update branch October 25, 2022 09:15
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
…team#5820)

Currently the `LightningNodeData` and `LightningLinkData` sets
`neighbor_sampler` to `NeighborSampler`. With this PR the user can
specify which sampler to use. This is useful if the user wants to use a
custom sampler, like some sort of remote sampler.

Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants