-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightningDataModule
: Add support for passing custom sampler
#5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5820 +/- ##
==========================================
+ Coverage 83.97% 84.09% +0.12%
==========================================
Files 349 349
Lines 19439 19451 +12
==========================================
+ Hits 16323 16358 +35
+ Misses 3116 3093 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
changed the title
Oct 25, 2022
LightningDataModule
: Add support for passing custom neighbor_sampler
.LightningDataModule
: Add support for passing custom sampler
rusty1s
approved these changes
Oct 25, 2022
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
…team#5820) Currently the `LightningNodeData` and `LightningLinkData` sets `neighbor_sampler` to `NeighborSampler`. With this PR the user can specify which sampler to use. This is useful if the user wants to use a custom sampler, like some sort of remote sampler. Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
LightningNodeData
andLightningLinkData
setsneighbor_sampler
toNeighborSampler
. With this PR the user can specify which sampler to use. This is useful if the user wants to use a custom sampler, like some sort of remote sampler.