Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow 1D input to global_*_pool functions #6504

Merged
merged 6 commits into from
Jan 24, 2023

Conversation

kgajdamo
Copy link
Contributor

Allow 1D input to global_*_pool functions

@kgajdamo kgajdamo requested a review from rusty1s January 24, 2023 11:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #6504 (076d667) into master (ecf4020) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 076d667 differs from pull request most recent head dac9afe. Consider uploading reports for the commit dac9afe to get more accurate results

@@            Coverage Diff             @@
##           master    #6504      +/-   ##
==========================================
- Coverage   85.69%   85.64%   -0.06%     
==========================================
  Files         406      405       -1     
  Lines       22665    22453     -212     
==========================================
- Hits        19423    19230     -193     
+ Misses       3242     3223      -19     
Impacted Files Coverage Δ
torch_geometric/nn/pool/glob.py 100.00% <100.00%> (ø)
torch_geometric/sampler/base.py 98.91% <0.00%> (-0.35%) ⬇️
torch_geometric/sampler/__init__.py 100.00% <0.00%> (ø)
torch_geometric/contrib/explain/__init__.py 100.00% <0.00%> (ø)
torch_geometric/contrib/explain/pgm_explainer.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/nn/pool/glob.py Outdated Show resolved Hide resolved
@rusty1s rusty1s changed the title allow 1D input to global_*_pool functions allow 1D input to global_*_pool functions Jan 24, 2023
@rusty1s rusty1s enabled auto-merge (squash) January 24, 2023 17:33
@rusty1s rusty1s merged commit b10b465 into pyg-team:master Jan 24, 2023
@kgajdamo kgajdamo deleted the global_pool_1d branch March 10, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants