Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Coverage] PNAConv and DegreeScalerAggregation #6600

Merged
merged 9 commits into from
Feb 6, 2023
Merged

[Code Coverage] PNAConv and DegreeScalerAggregation #6600

merged 9 commits into from
Feb 6, 2023

Conversation

zechengz
Copy link
Member

@zechengz zechengz commented Feb 5, 2023 •
edited
Loading

PNAConv test coverage

@zechengz zechengz requested a review from rusty1s February 5, 2023 11:02
@codecov
Copy link

codecov bot commented Feb 5, 2023 •
edited
Loading

Codecov Report

Merging #6600 (9bf0fbd) into master (33f22b9) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 9bf0fbd differs from pull request most recent head 960428a. Consider uploading reports for the commit 960428a to get more accurate results

@@            Coverage Diff             @@
##           master    #6600      +/-   ##
==========================================
+ Coverage   87.39%   87.43%   +0.03%     
==========================================
  Files         421      421              
  Lines       22912    22912              
==========================================
+ Hits        20025    20033       +8     
+ Misses       2887     2879       -8
Impacted Files Coverage Δ
torch_geometric/nn/aggr/scaler.py 98.00% <0.00%> (+4.00%) ⬆️
torch_geometric/nn/conv/pna_conv.py 100.00% <0.00%> (+7.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zechengz zechengz marked this pull request as ready for review February 5, 2023 11:08
@zechengz zechengz requested review from wsad1 and lightaime February 5, 2023 11:56
lightaime
lightaime reviewed Feb 5, 2023
View reviewed changes
Copy link
Contributor

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! Leave a few minor comments.

test/nn/conv/test_pna_conv.py Outdated Show resolved Hide resolved
test/nn/conv/test_pna_conv.py Outdated Show resolved Hide resolved
torch_geometric/nn/conv/pna_conv.py Outdated Show resolved Hide resolved
@rusty1s rusty1s mentioned this pull request Feb 6, 2023
Closed
58 tasks
@zechengz zechengz requested a review from lightaime February 6, 2023 10:03
@lightaime lightaime changed the title [Code Coverage] PNAConv [Code Coverage] PNAConv and DegreeScalerAggregation Feb 6, 2023
lightaime
lightaime approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rusty1s
rusty1s reviewed Feb 6, 2023
View reviewed changes
test/nn/aggr/test_scaler.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) February 6, 2023 12:34
@rusty1s rusty1s merged commit 53e3a3e into pyg-team:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightaime lightaime lightaime approved these changes

@rusty1s rusty1s rusty1s approved these changes

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

Assignees

@zechengz zechengz

Labels
nn test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zechengz @rusty1s @lightaime