Make LinkX model jittable
#6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6712 +/- ##
==========================================
+ Coverage 88.97% 89.05% +0.08%
==========================================
Files 423 423
Lines 22965 22978 +13
==========================================
+ Hits 20433 20464 +31
+ Misses 2532 2514 -18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
Feb 15, 2023
rusty1s
added a commit
that referenced
this pull request
Feb 17, 2023
This PR add the TorchScript support for `RECT_L` model. The fail reason and our solution for original code is very similar with PR [#6721](#6712), except that this model using the `torch.jit.export` on `embed` and `get_semantic_labels` methods. And another fail reason is `@torch.no_grad`, which bring some error msg I cann't understand. Adding TorchScript support will bring a lot of extra code and reduce the code readability. I will consider how to do better in another PR. --------- Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the LinkX model to be jittable and get better performance.
The original LinkX model cann't be JIT due to many reasons:
edge_indexof LinkX.forward isAdj. So we need to add@torch.jit._overload_methodfor this method.edge_normandedge_mlpin LinkX model isn't always initialized. So we modify the initialize logic.@torch.jit._overload_methodfor forward, we need a wrapper of model. Overwise, the TorchScript can't find the forward function.Union, which will caused type error in TorchScript when we use the return value of MLP.I think there might be a better way to make it jittable, but I haven't found yet.