Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch Sparse tensor support: GATConv, GatedGraphConv, GCN2Conv, and GENConv #6897

Merged
merged 10 commits into from
Mar 16, 2023

Conversation

EdisonLeeeee
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #6897 (27828f8) into master (688c754) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6897      +/-   ##
==========================================
- Coverage   91.80%   91.50%   -0.30%     
==========================================
  Files         428      428              
  Lines       23254    23235      -19     
==========================================
- Hits        21348    21261      -87     
- Misses       1906     1974      +68     
Impacted Files Coverage Δ
torch_geometric/nn/conv/fa_conv.py 95.00% <ø> (ø)
...ch_geometric/explain/algorithm/captum_explainer.py 98.73% <100.00%> (-1.27%) ⬇️
torch_geometric/nn/conv/gat_conv.py 100.00% <100.00%> (ø)
torch_geometric/nn/conv/gen_conv.py 95.28% <100.00%> (+0.23%) ⬆️
torch_geometric/utils/loop.py 100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/utils/loop.py Outdated Show resolved Hide resolved
torch_geometric/utils/loop.py Outdated Show resolved Hide resolved
torch_geometric/utils/loop.py Outdated Show resolved Hide resolved
@rusty1s
Copy link
Member

rusty1s commented Mar 15, 2023

@EdisonLeeeee Can we add a test for the add_self_loops change?

@rusty1s rusty1s merged commit 5f1e4a2 into master Mar 16, 2023
@rusty1s rusty1s deleted the sparse_tensor branch March 16, 2023 08:30
@EdisonLeeeee
Copy link
Contributor Author

Sorry for not being able to respond and address the comments promptly. Thank you @rusty1s for making it merged.

@rusty1s
Copy link
Member

rusty1s commented Mar 16, 2023

No worries, it was a fun exercise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants