Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unbatching support for torch.sparse.Tensor #7037

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

DomInvivo
Copy link
Contributor

This PR allows to fix the issues with Batch.from_data_list or Batch.get_example or Batch__getitem__ when using pytorch's sparse tensors, such as sparse_coo_tensor. See issue #7022

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #7037 (56b8c59) into master (d3f4471) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

❗ Current head 56b8c59 differs from pull request most recent head 097aa66. Consider uploading reports for the commit 097aa66 to get more accurate results

@@            Coverage Diff             @@
##           master    #7037      +/-   ##
==========================================
- Coverage   91.52%   91.52%   -0.01%     
==========================================
  Files         436      436              
  Lines       23832    23841       +9     
==========================================
+ Hits        21813    21821       +8     
- Misses       2019     2020       +1     
Impacted Files Coverage Δ
torch_geometric/data/separate.py 98.27% <90.90%> (-1.73%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title Adding a different logic for the unbatching of torch Adding for unbatching of torch.sparse.Tensor Mar 27, 2023
@rusty1s rusty1s changed the title Adding for unbatching of torch.sparse.Tensor Adding unbatching support for torch.sparse.Tensor Mar 27, 2023
@rusty1s rusty1s enabled auto-merge (squash) March 27, 2023 08:30
@rusty1s rusty1s merged commit 0e439f3 into pyg-team:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch.get_example fails when using sparse_coo_tensor for the tensor values
2 participants