Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch_size and max_num_nodes argument in MemPooling layer #7239

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

piotrchmiel
Copy link
Contributor

It can be used to avoid additional calculations if a user is using fixed-size batch.

It can be used to avoid additional calculations if a user is using
fixed-size batch.
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #7239 (d546c08) into master (0c4ea3a) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

❗ Current head d546c08 differs from pull request most recent head 0a8a1f0. Consider uploading reports for the commit 0a8a1f0 to get more accurate results

@@            Coverage Diff             @@
##           master    #7239      +/-   ##
==========================================
- Coverage   92.04%   91.61%   -0.44%     
==========================================
  Files         437      437              
  Lines       24145    24142       -3     
==========================================
- Hits        22225    22118     -107     
- Misses       1920     2024     +104     
Impacted Files Coverage Δ
torch_geometric/nn/pool/mem_pool.py 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/nn/pool/mem_pool.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) April 26, 2023 14:36
@rusty1s rusty1s changed the title Add batch_size and max_num_nodes argument for MemPooling layer. Add batch_size and max_num_nodes argument in MemPooling layer Apr 26, 2023
@rusty1s rusty1s disabled auto-merge April 26, 2023 14:36
@rusty1s rusty1s enabled auto-merge (squash) April 26, 2023 14:36
@rusty1s rusty1s changed the title Add batch_size and max_num_nodes argument in MemPooling layer Add batch_size and max_num_nodes argument in MemPooling layer Apr 26, 2023
@rusty1s rusty1s disabled auto-merge April 26, 2023 14:37
@rusty1s rusty1s enabled auto-merge (squash) April 26, 2023 14:37
CHANGELOG.md Outdated Show resolved Hide resolved
@rusty1s rusty1s disabled auto-merge April 26, 2023 14:52
@rusty1s rusty1s merged commit 5778c65 into pyg-team:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants