Introduce disable_dynamic_shapes experimental flag; adding its use into to_dense_batch function
#7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrchmiel
force-pushed
the
piotrc/disable_dynamic_shapes
branch
from
b397d85 to
f98c31a
Compare
Codecov Report
@@ Coverage Diff @@
## master #7246 +/- ##
==========================================
+ Coverage 91.42% 91.50% +0.08%
==========================================
Files 446 446
Lines 24827 24862 +35
==========================================
+ Hits 22697 22750 +53
+ Misses 2130 2112 -18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
piotrchmiel
force-pushed
the
piotrc/disable_dynamic_shapes
branch
from
f98c31a to
3c1e5bb
Compare
rusty1s
reviewed
Apr 27, 2023
rusty1s
changed the title
disable_dynamic_shapes experimental flag; adding its use into to_dense_batch function
piotrchmiel
force-pushed
the
piotrc/disable_dynamic_shapes
branch
from
a92cb50 to
da67240
Compare
piotrchmiel
force-pushed
the
piotrc/disable_dynamic_shapes
branch
from
da67240 to
0a048d8
Compare
into to_dense_batch function. There are devices that do not support dynamic shapes - (compiling and optimizing only static graphs). The ability to set and read the "disable_dynamic_shapes" flag allows implementors to provide static shape-friendly implementations and report user-friendly messages if it is impossible to avoid using dynamic shapes.
piotrchmiel
force-pushed
the
piotrc/disable_dynamic_shapes
branch
from
0a048d8 to
b03d33e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are devices that do not support dynamic shapes - (compiling and optimizing only static graphs). The ability to set and read the "disable_dynamic_shapes" flag allows implementors to provide static shape-friendly implementations and report user-friendly messages if it is impossible to avoid using dynamic shapes.