Pooling: Update base classes
#7307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7307 +/- ##
==========================================
- Coverage 92.07% 91.40% -0.67%
==========================================
Files 438 437 -1
Lines 24303 24306 +3
==========================================
- Hits 22378 22218 -160
- Misses 1925 2088 +163
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6455.
This PR makes the following changes
Poolingbase class. The current implementation isn't flexible enough to support all pooling operators. Instead pooling operators will implement their own forward method, usingSelect,ConnectandAggregateoperators.Selectoperator. It now returnsSelectOutputwhich containsnode_index,cluster_index,num_clustersandweight. Whereweightis the weight given to a node assignment to a cluster.