Add GraphLearn-for-PyTorch(GLT) distributed examples #7402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rusty1s
reviewed
May 24, 2023
There was a problem hiding this comment.
Can we move this example to examples/distributed/GLT?
There was a problem hiding this comment.
example moved into examples/distributed/glt
| @@ -0,0 +1,69 @@ | |||
| # Using GraphLearn-for-PyTorch(GLT) for Distributed Acceleration for PyG | |||
|
|
|||
| **[GraphLearn-for-PyTorch(GLT)](https://github.com/alibaba/graphlearn-for-pytorch)** is a graph learning library for PyTorch that makes | |||
There was a problem hiding this comment.
I would be in favor of writing each sentence in a new line. This leads to cleaner diffs.
Comment on lines
20
to
24
| ### Requirements | ||
| - cuda>=11.4 | ||
| - python>=3.6 | ||
| - torch(PyTorch)>=1.13 | ||
| - torch_geometric, torch_scatter, torch_sparse. Please refer to [PyG](https://github.com/pyg-team/pytorch_geometric) for installation. |
|
|
||
| Let's take PyG's [GraphSAGE on OGBN-Products](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/ogbn_products_sage.py) | ||
| as an example. To benefit from the acceleration by using GLT, you only need to replace PyG's `torch_geometric.loader.NeighborLoader` | ||
| by the `graphlearn_torch.loader.NeighborLoader`, which is . |
Comment on lines
1
to
15
| # Copyright 2022 Alibaba Group Holding Limited. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # ============================================================================== | ||
|
|
There was a problem hiding this comment.
Is this copyright section necessary?
| x = model(batch.x, batch.edge_index)[:batch.batch_size] | ||
| xs.append(x.cpu()) | ||
| y_true.append(batch.y[:batch.batch_size].cpu()) | ||
| del batch |
baoleai
reviewed
May 24, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GraphLearn-for-PyTorch(GLT) distributed example integrated with PyG GraphSAGE model.