Fix a bug in the QuantileAggregation with the dim size parameter passed
#7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passed. Passing the `dim_size` parameter led to `index out of range` error, during `index_select` operation. Setting parameters `dim_size` and `fill_value` has not been tested, appropriate tests have been added.
piotrchmiel
force-pushed
the
piotrc/quantile_aggr
branch
from
ae69d78 to
62a295d
Compare
Codecov Report
@@ Coverage Diff @@
## master #7407 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 440 440
Lines 24574 24576 +2
=======================================
+ Hits 22441 22443 +2
Misses 2133 2133
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the
dim_sizeparameter led to anindex out of rangeerror, during theindex_selectoperation. Setting parametersdim_sizeandfill_valuehas not been tested, appropriate tests have been added.