Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Page for HGAM #7594

Merged
merged 15 commits into from
Jun 19, 2023
Merged

Conversation

andreazanetti
Copy link
Contributor

Adding a documentation page for HGAM.
The idea is to pass the following information to the user:

a) high level perspective of what HGAM is
b) role of BFS ordering of the graph batch for HGAM to work
c) support in the neighbor loader
d) practical working example of TrimToLayer class
e) pointers to external resources

This is a draft, asking for preliminary feedback.
Thanks for any input!

Contributors: @mszarma, @rBenke (robert.benke@intel.com), manos.farsarakis@intel.com

@andreazanetti andreazanetti self-assigned this Jun 16, 2023
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thank you :) Eventually, we can extend this tutorial by some figures to show the difference in GNN computation visually as well.

@rusty1s rusty1s marked this pull request as ready for review June 19, 2023 12:24
@rusty1s rusty1s enabled auto-merge (squash) June 19, 2023 12:37
@rusty1s rusty1s merged commit d0075a8 into pyg-team:master Jun 19, 2023
@andreazanetti
Copy link
Contributor Author

Thanks Matthias for working on it, and merging it!
We will then open a new PR in the next days, adding some figures to show pictorially how computation changes with HGAM (HSN).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants