Add distributed feature info for distributed training #7678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7678 +/- ##
==========================================
- Coverage 91.58% 91.05% -0.54%
==========================================
Files 452 454 +2
Lines 25534 25783 +249
==========================================
+ Hits 23385 23476 +91
- Misses 2149 2307 +158
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mananshah99
reviewed
Jul 6, 2023
There was a problem hiding this comment.
Can we rebase this PR on the other two PRs to avoid a duplicated diff? Otherwise, this one is hard to review.
rusty1s
added a commit
that referenced
this pull request
Aug 7, 2023
This code belongs to the part of the whole distributed training for PyG. (This PR is to replace #7678) This PR originally designed for the DistFeature class and now merged with LocalFeatureStore - Add partition/rpc info into LocalFeatureStore like num_partition, partition_idx, feature_pb (feature_partitionbook), partition_meta, RpcRouter, etc Add one new class (RpcCallFeatureLookup) to do real remote rpc feature_lookup work Add one api ( .lookup_features() ) to do feature lookup in local node and remote nodes based on sampled global node ids/edge ids based on torch rpc apis one unit test to verify the function of local/remote feature lookup under .test/distributed/. folder Now we combined the local feature store and distributed feature properties (partition info and rpc remote access apis) into one FeatureStore. later on we will change the class name from LocalFeatureStore into PartitionFeatureStore with another PR. Any comments please let us know. thanks. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de> Co-authored-by: root <root@skyocean.sh.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code belongs to the part of the whole distributed training for PyG.
This PR originally designed for the DistFeature class and now merged with LocalFeatureStore -
Now we combined the local feature store and distributed feature properties (partition info and rpc remote access apis) into one FeatureStore. later on we will change the class name from LocalFeatureStore into PartitionFeatureStore with another PR.
Any comments please let us know. thanks.