Fix LinkNeighborLoader producing double-sized edge_label_time for homogeneous graphs
#7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
force-pushed
the
test/loader
branch
from
60ea03b to
00b542a
Compare
for more information, see https://pre-commit.ci
This reverts commit a3e6801.
akihironitta
force-pushed
the
test/loader
branch
from
f162dea to
51f30c9
Compare
akihironitta
force-pushed
the
test/loader
branch
from
841e7ec to
2c95b33
Compare
akihironitta
changed the title
LinkNeighborLoaderLinkNeighborLoader producing double-sized edge_label_time for homogeneous graphs
akihironitta
commented
Jul 28, 2023
|
|
||
| for sample in loader: | ||
| assert sample.edge_label_index.size() == (2, batch_size) | ||
| assert sample.edge_label_time.size() == (batch_size, ) |
There was a problem hiding this comment.
Before this PR, the size of edge_label_time was (2*batch_size, ).
Codecov Report
@@ Coverage Diff @@
## master #7807 +/- ##
=======================================
Coverage 91.57% 91.58%
=======================================
Files 455 455
Lines 25670 25656 -14
=======================================
- Hits 23507 23496 -11
+ Misses 2163 2160 -3
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akihironitta
commented
Jul 28, 2023
Comment on lines
230
to
231
| # TODO(akihironitta): Investigate the failure | ||
| # assert torch.all(sample.edge_time <= sample.edge_label_time) |
There was a problem hiding this comment.
Could someone also confirm this assertion is correct before I dig into this?
rusty1s
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
edge_label_time.size() == (2*batch_size,)to have(batch_size,).Adds a test case for #7791.
Part of #7796 and #6528.