Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store global node IDs for partitioned graphs #7910

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Store global node IDs for partitioned graphs #7910

merged 5 commits into from
Aug 21, 2023

Conversation

kaixuanliu
Copy link
Contributor

@rusty1s For distributed pyg training development, we prefer to use global node ids to represent partitioned graph store. It would be convenient for us to neighbor sample the partitioned graph if we use global ids for rows/cols.

Signed-off-by: Liu,Kaixuan <kaixuan.liu@intel.com>
@kaixuanliu
Copy link
Contributor Author

@ZhengHongming888

Signed-off-by: Liu,Kaixuan <kaixuan.liu@intel.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #7910 (5c96900) into master (deff5a4) will decrease coverage by 0.80%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 5c96900 differs from pull request most recent head e18b7b9. Consider uploading reports for the commit e18b7b9 to get more accurate results

@@            Coverage Diff             @@
##           master    #7910      +/-   ##
==========================================
- Coverage   90.16%   89.36%   -0.80%     
==========================================
  Files         457      457              
  Lines       26821    26826       +5     
==========================================
- Hits        24182    23974     -208     
- Misses       2639     2852     +213     
Files Changed Coverage Δ
torch_geometric/distributed/partition.py 99.15% <100.00%> (+0.06%) ⬆️

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit 309576a into pyg-team:master Aug 21, 2023
@rusty1s rusty1s changed the title using global node ids for partitioned graph's row/col Store global node IDs for partitioned graphs Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants