Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed view to reshape in LCMAggregation #8026

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

ArchieGertsman
Copy link
Contributor

view resulted in an error in some cases, so I changed it to reshape. I also modified the tests to reflect such a scenario.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #8026 (5a961d0) into master (3e69022) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8026   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         464      464           
  Lines       27453    27453           
=======================================
+ Hits        24319    24320    +1     
+ Misses       3134     3133    -1     
Files Changed Coverage Δ
torch_geometric/nn/aggr/lcm.py 94.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 13cbae6 into pyg-team:master Sep 14, 2023
@ArchieGertsman ArchieGertsman deleted the lcm_optimized branch September 15, 2023 01:29
JakubPietrakIntel pushed a commit that referenced this pull request Sep 27, 2023
`view` resulted in an error in some cases, so I changed it to `reshape`.
I also modified the tests to reflect such a scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants