Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cuda to multigpu (xpu) bench #8386

Merged
merged 14 commits into from
Nov 16, 2023
Merged

Add cuda to multigpu (xpu) bench #8386

merged 14 commits into from
Nov 16, 2023

Conversation

puririshi98
Copy link
Contributor

No description provided.

@puririshi98 puririshi98 self-assigned this Nov 15, 2023
@puririshi98 puririshi98 requested a review from a team as a code owner November 15, 2023 23:57
DamianSzwichtenberg
DamianSzwichtenberg approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@DamianSzwichtenberg DamianSzwichtenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed changes that separate CUDA and XPU starting points. This approach fixes all XPU-related errors + makes things a bit clearer (I've also tested CUDA path, though only using 1 GPU).

@puririshi98
Copy link
Contributor Author

thanks!, works for multigpu too

@puririshi98 puririshi98 enabled auto-merge (squash) November 16, 2023 19:22
@puririshi98 puririshi98 merged commit aff3a99 into master Nov 16, 2023
12 checks passed
@puririshi98 puririshi98 deleted the add-cuda-to-bench branch November 16, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianSzwichtenberg DamianSzwichtenberg DamianSzwichtenberg approved these changes

@rusty1s rusty1s Awaiting requested review from rusty1s

Assignees

@puririshi98 puririshi98

Labels
benchmark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puririshi98 @DamianSzwichtenberg