Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.compile benchmark for HeteroConv; Allow device conversions of datasets #8402

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Nov 19, 2023

+----------+-----------+------------+---------+
| Name     | Forward   | Backward   | Total   |
|----------+-----------+------------+---------|
| Vanilla  | 2.0331s   | 0.5175s    | 2.5505s |
| Compiled | 0.6899s   | 0.6946s    | 1.3844s |
+----------+-----------+------------+---------+

@rusty1s rusty1s self-assigned this Nov 19, 2023
@rusty1s rusty1s changed the title torch.compile benchmark for HeteroConv torch.compile benchmark for HeteroConv; Allow device conversions of datasets Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (cf24b4b) 88.36% compared to head (11c1e25) 87.71%.
Report is 2 commits behind head on master.

Files Patch % Lines
torch_geometric/data/in_memory_dataset.py 20.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8402      +/-   ##
==========================================
- Coverage   88.36%   87.71%   -0.66%     
==========================================
  Files         475      475              
  Lines       28894    28918      +24     
==========================================
- Hits        25532    25364     -168     
- Misses       3362     3554     +192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit ea2ab70 into master Nov 19, 2023
16 of 17 checks passed
@rusty1s rusty1s deleted the hetero_conv_compile2 branch November 19, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant