Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable torch._inductor.config.assert_indirect_indexing in PyTorch 2.2 #8507

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

akihironitta
Copy link
Member

@akihironitta akihironitta commented Dec 1, 2023

For PyTorch 2.1, #8220 disabled assert_indirect_indexing, but pytorch/pytorch#108690 moved assert_indirect_indexing out of triton config, and the change should land in the next feature release, PyTorch 2.2:

# PyTorch 2.2
torch._inductor.config.assert_indirect_indexing = False

# PyTorch 2.1
torch._inductor.config.triton.assert_indirect_indexing = False

@akihironitta akihironitta self-assigned this Dec 1, 2023
@akihironitta akihironitta changed the title Update compile.py Disable torch._inductor.config.assert_indirect_indexing in PyTorch 2.2 Dec 1, 2023
@akihironitta akihironitta enabled auto-merge (squash) December 1, 2023 22:13
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (abc0071) 88.28% compared to head (5fc2232) 88.28%.

Files Patch % Lines
torch_geometric/compile.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8507   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         479      479           
  Lines       29656    29658    +2     
=======================================
+ Hits        26181    26183    +2     
  Misses       3475     3475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akihironitta akihironitta merged commit fce7466 into master Dec 2, 2023
13 of 14 checks passed
@akihironitta akihironitta deleted the akihironitta-patch-2 branch December 2, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants