Add relabel node functionality to dropout_node
#8524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8524 +/- ##
==========================================
+ Coverage 88.38% 88.50% +0.11%
==========================================
Files 479 479
Lines 29721 29714 -7
==========================================
+ Hits 26270 26299 +29
+ Misses 3451 3415 -36 ☔ View full report in Codecov by Sentry. |
EdisonLeeeee
approved these changes
Dec 5, 2023
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Dec 5, 2023
rusty1s
changed the title
dropout_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dropout_node function removes any edge containing a dropped node from the edge_index. It also produces an node mask to remove nodes encodings from x. However, the edge_mask doesn't have the option to relabel nodes accordingly. If node n is dropped and we use the node mask, node n+1 is now the nth node in x, but the edge set still references it as n+1.
This functionality can be added by feeding the relabel node flag directly to the subgraph call in relabel_node