Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KNNIndex exclusion logic #8573

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Add KNNIndex exclusion logic #8573

merged 2 commits into from
Dec 8, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Dec 8, 2023

No description provided.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9dea80a) 88.73% compared to head (d8e2315) 88.73%.

Files Patch % Lines
torch_geometric/nn/pool/knn.py 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8573      +/-   ##
==========================================
- Coverage   88.73%   88.73%   -0.01%     
==========================================
  Files         479      479              
  Lines       29810    29842      +32     
==========================================
+ Hits        26453    26480      +27     
- Misses       3357     3362       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 64fc4c1 into master Dec 8, 2023
13 checks passed
@rusty1s rusty1s deleted the exclude_knn branch December 8, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant