Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of InMemoryDataset in case a pre_transform modifies the underlying Data class #8692

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Fix loading of InMemoryDataset in case a pre_transform modifies the underlying Data class #8692

merged 3 commits into from
Dec 30, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Dec 30, 2023

Fixes #8688

@rusty1s rusty1s self-assigned this Dec 30, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5a5950c) 89.50% compared to head (7bf1355) 89.49%.

Files Patch % Lines
torch_geometric/data/in_memory_dataset.py 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8692      +/-   ##
==========================================
- Coverage   89.50%   89.49%   -0.01%     
==========================================
  Files         481      481              
  Lines       31079    31084       +5     
==========================================
+ Hits        27816    27819       +3     
- Misses       3263     3265       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit d1f305b into master Dec 30, 2023
14 checks passed
@rusty1s rusty1s deleted the pre_transform_fix branch December 30, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@mananshah99 mananshah99 Awaiting requested review from mananshah99 mananshah99 is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug data dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rusty1s