-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinCut pooling for sparse adjacency matrix #9243
Open
xiaohan2012
wants to merge
33
commits into
pyg-team:master
Choose a base branch
from
xiaohan2012:sparse-mincut-pool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…eometric into sparse-mincut-pool
for more information, see https://pre-commit.ci
…eometric into sparse-mincut-pool
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9243 +/- ##
==========================================
+ Coverage 86.59% 87.36% +0.76%
==========================================
Files 482 483 +1
Lines 31460 31538 +78
==========================================
+ Hits 27242 27552 +310
+ Misses 4218 3986 -232 ☔ View full report in Codecov by Sentry. |
…eometric into sparse-mincut-pool
…eometric into sparse-mincut-pool
@wsad1 @EdisonLeeeee @rusty1s can I ask for a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
nn.dense.mincut_pool
requires the input adjacency matrix to be a dense matrix. This requirement does not scale to large graphsWhat
This PR considers a sparse counterpart of
nn.dense.mincut_pool
, which takes in sparse adjacency matrix as input.Speed comparison with dense mincut
The script
Remark on matrix multiplication
torch.sparse.mm
is used, therefore restricting the use to COO matrices only. As a future work, multiplying CSR matrix with CSC matrix should be used for better performance