-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support int and str input for color values in video module #2400
Conversation
yunline
commented
Aug 15, 2023
- remove Texture._color - Support int and str for `Texture.color` and `Image.color`
This PR seemingly relies on #2349, so that must be merged first. |
The PR this PR depended on has been merged, though this still has extra commits? Fix with a rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left a comment, there's also a merge conflict. The ALL color flag is the same one used by the Color constructor, that's good. It's probably good to just have that be the standard and never support mapped color for Textures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!