Correct casing for macOS #2538
Merged
Correct casing for macOS #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there other cases this should be changed? |
|
Yeah, give me one second. |
ankith26
reviewed
Oct 30, 2023
|
Though for some reason the CI doesn't like it. I'm guessing that actual script variable name change is breaking something |
|
CI doesn't like it because the branch of this PR is not on this repo, and this change is triggering a docker image rebuild. I think we can safely ignore this fail, upon merging this PR, the error should not persist. |
ankith26
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source: https://www.apple.com/macos/sonoma/