Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blend from draw.aaline #2550

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Remove blend from draw.aaline #2550

merged 4 commits into from
Nov 9, 2023

Conversation

MightyJosip
Copy link
Contributor

@MightyJosip MightyJosip commented Nov 6, 2023 •
edited
Loading

Already done in #2506, but there was still some stuff that used blend argument.

@MightyJosip MightyJosip requested a review from a team as a code owner November 6, 2023 09:22
@MyreMylar
Copy link
Member

Looks like this needs running through the linters.

MyreMylar
MyreMylar approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yunline yunline added the draw pygame.draw label Nov 7, 2023
dr0id
dr0id approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankith26
ankith26 requested changes Nov 7, 2023
View reviewed changes
src_c/draw.c Show resolved Hide resolved
ankith26
ankith26 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👑

@ankith26 ankith26 merged commit f787dda into pygame-community:main Nov 9, 2023
@ankith26 ankith26 added this to the 2.4.0 milestone Nov 9, 2023
@MightyJosip MightyJosip deleted the remove_blend branch November 9, 2023 18:52
oddbookworm added a commit to oddbookworm/pygame-ce that referenced this pull request Mar 7, 2024
@oddbookworm
Revert "Remove blend from draw.aaline (pygame-community#2550)"
682735f 
This reverts commit f787dda.

	modified:   src_c/draw.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0id dr0id dr0id approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
draw pygame.draw
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MightyJosip @MyreMylar @dr0id @ankith26 @yunline