Attempt to make pygame.Rect() possible - DRAFT #2554
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I'm making a draft PR is because I'm having issues with setting up a local environment, in particular with the vsvarsal.bat file. If anyone reading this want to help, I'm on the dc pygame-ce server as Damus666 (@damusss).
Making the PR should technically give me compilation and run the py tests automatically.
There are a few reasons why I think pygame.Rect() should be a thing:
Where could you need to make an empty rect?
I've never edited the C source code in a PR (except for some PyObject *_null arguments, which i couldn't really mess up) so i could mess up a lot of things, reviews are welcome.