Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Window parameter name allow_highdpi -> allow_high_dpi #2704

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix Window parameter name allow_highdpi -> allow_high_dpi #2704

merged 1 commit into from
Jan 31, 2024

Conversation

szabolcsdombi
Copy link
Contributor

@szabolcsdombi szabolcsdombi commented Jan 30, 2024 •
edited
Loading

Please see:

pygame-ce/src_c/window.c

Line 857 in ec5e6f8

else if (!strcmp(_key_str, "allow_high_dpi")) {

@szabolcsdombi szabolcsdombi requested a review from a team as a code owner January 30, 2024 18:40
Starbuck5
Starbuck5 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked some old sources, and this actually did used to be allow_highdpi when Window was implemented in Cython.

That being said, I'm fine to move forward with is as it is currently named. Thanks for the PR.

@Starbuck5 Starbuck5 added docs window pygame.Window labels Jan 31, 2024
ankith26
ankith26 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing! 🥳

@ankith26 ankith26 added this to the 2.5.0 milestone Jan 31, 2024
@ankith26 ankith26 merged commit ddc98bd into pygame-community:main Jan 31, 2024
2 checks passed
Starbuck5 pushed a commit that referenced this pull request Feb 18, 2024
@ankith26 @Starbuck5
Merge pull request #2704 from szabolcsdombi/patch-1
f479968 
Fix Window parameter name allow_highdpi -> allow_high_dpi
@Starbuck5 Starbuck5 modified the milestones: 2.5.0, 2.4.1 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
docs window pygame.Window
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@szabolcsdombi @Starbuck5 @ankith26