Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Freetype) use calloc where possible #2802

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

Starbuck5
Copy link
Member

I was poking around freetype and saw some malloc+memset pairs, which could instead be expressed as a calloc.

This is slightly simpler code to do, and might be faster. *Not that perf really matters for these calls, they are infrequent.

@Starbuck5 Starbuck5 added Code quality/robustness Code quality and resilience to changes freetype pygame.freetype labels Apr 14, 2024
@Starbuck5 Starbuck5 requested a review from a team as a code owner April 14, 2024 06:35
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@Starbuck5 Starbuck5 force-pushed the freetype-use-calloc branch from 3979125 to 2b177bc Compare April 14, 2024 06:46
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit bdd533f into pygame-community:main Apr 14, 2024
36 checks passed
@Starbuck5 Starbuck5 deleted the freetype-use-calloc branch April 14, 2024 22:16
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality/robustness Code quality and resilience to changes freetype pygame.freetype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants