Track version only in pyproject.toml #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-unify-version
branch
from
f85ef6b to
ca42fdd
Compare
oddbookworm
approved these changes
Apr 27, 2024
MyreMylar
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every time we bump the version, we have to update the version in like 4 files, and in some cases multiple lines within these files.
We already have a mechanism to read the version info defined in
pyproject.tomlin python. This mechanism was recently implemented to be used in the meson buildconfig so that we don't have to re-define the version there.I'm taking that a step further in this PR, and now this file can be used in all places that needs a version. After this PR, there will be only one line in the codebase that defines the version (in the
pyproject.tomlfile)