Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #2847

Merged
merged 3 commits into from
May 18, 2024
Merged

fix typos #2847

merged 3 commits into from
May 18, 2024

Conversation

RainRat
Copy link
Contributor

@RainRat RainRat commented May 12, 2024

fix typos

@RainRat
fix typos
779efd7 
fix typos
@RainRat RainRat requested a review from a team as a code owner May 12, 2024 01:51
oddbookworm
oddbookworm approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great. I'm not going to miss fronzensets lol

@oddbookworm
Copy link
Member

Oh yeah, you should make sure to run python setup format to get the lint check passing. You can install pre-commit to catch any outstanding linter errors before your commit happens
I'll go update the contributing wiki now...

gresm
gresm reviewed May 12, 2024
View reviewed changes
docs/reST/c_api/color.rst Outdated Show resolved Hide resolved
oddbookworm
oddbookworm requested changes May 13, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The circleCI fail from the most recent run isn't your fault, it's a freetype download issue that's been intermittently cropping up. But, the lint fail needs to be addressed before this can be merged

src_c/mask.c Outdated Show resolved Hide resolved
@RainRat
do requested changes + new typo
b28a452 
no functional change
ankith26
ankith26 approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing! 🎉

@ankith26
Copy link
Member

PS: ignore the new failing test, it is unrelated to your PR

oddbookworm
oddbookworm approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddbookworm oddbookworm merged commit a21ccf2 into pygame-community:main May 18, 2024
38 of 39 checks passed
@ankith26 ankith26 added this to the 2.5.0 milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gresm gresm gresm left review comments

@oddbookworm oddbookworm oddbookworm approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RainRat @oddbookworm @ankith26 @gresm