Run display autoinit on window API, fixes #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-window-autoinit
branch
from
0361ccd to
e5c5ae1
Compare
oddbookworm
reviewed
May 20, 2024
ankith26
force-pushed
the
ankith26-window-autoinit
branch
from
e5c5ae1 to
ed157de
Compare
|
is this really how we want to to things? Why not a warning that pygame is not initialised? |
|
I would not have minded the raise warning/error approach, but then I also don't see a problem with the currently implemented approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2605
This PR takes the
display.set_mode-like approach and implicitly calls display init whenever a window is constructed.