-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a briefcase template to pygame-ce #2862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just have one small thing that might be fine to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, LGTM 👍
Tested it on my machine and got a hello world briefcase test program running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just went through the process of created a .deb
package, and it went really smooth! I'm really starting to like this tool.
Does the .deb depend on pygame-ce, or does it bundle its own SDL, pygame, and so on? |
It bundles the stuff in the If a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has my approval. Even though I left a question, I feel it's better to merge this in for 2.5.0 anyways, as we can polish this up in future releases.
I think it is completely self-contained, I might do some testing later with a couple of ubuntu VM's that don't already have things installed |
Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
This is similar to the PyInstaller hook we have, but for Briefcase, another distribution solution. (https://beeware.org/project/projects/tools/briefcase/)
The template and strategy are largely copied from the existing entrypoints in the briefcase library.
Worked on this during the Beeware sprint at Pycon US 2024.
I think this supersedes beeware/briefcase#1804
To test, install briefcase with pip, install pygame-ce from this branch, and run
briefcase new
. After going through the briefcase options, it will have a "GUI Framework" option that will now report pygame-ce as an option. This works as a template for pygame-ce in briefcase, but is not necessary for supporting distributing pygame-ce apps in briefcase.After this PR (in
briefcase new
):