Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter CODEOWNERS file to switch required PR review team #2873

Merged
merged 1 commit into from
May 25, 2024

Conversation

MyreMylar
Copy link
Member

The intention being that we can choose to expand our pool of senior reviewers beyond just the current maintainers. This may be important when one of the current maintainers retires from the role but is still active in the project and interested in reviewing.

I hope expanding this pool might help tackle the current 72 open PR review mountain somewhat over time.

The current "senior/seasoned reviewers" team is here:

https://github.com/orgs/pygame-community/teams/pygame-senior-reviewers

and right now this team is identical with the current maintainers.

Other things we could consider with the CODEOWNERS file:

  • Letting Pull Requests with only changes in the docs/ folder pass with just two reviews from any current member of the pygame organisation.
  • Having teams or individuals who have the required reviewing power only over *.c files or *.py files if they are only confident in one language.

The file has cascading 'ownership', so more specific ownership lower down the file takes precedence over broader 'ownership' higher up. You can read more about customising the file here:

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

The intention being that we can choose to expand our pool of senior reviewers beyond just the current maintainers.

I hope expanding this pool might help tackle the PR review mountain somewhat over time.
@MyreMylar MyreMylar requested a review from a team as a code owner May 25, 2024 09:39
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, I'm all for it 👍

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddbookworm oddbookworm merged commit 6df3c15 into main May 25, 2024
36 checks passed
@ankith26 ankith26 deleted the seasoned-reviewers-team branch June 3, 2024 10:44
@ankith26 ankith26 added this to the 2.5.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants