Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs/stubs improvements in invlerp/remap #2902

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Jun 2, 2024

Just a follow up PR to #2654

The main goal of doing this PR was to fix the ZeroDivisionError mentioned in the docs to ValueError, which is what is actually raised in the code. Also made one argument name in stubs consistent with the docs.

While I was editing the docs, I also polished it up a bit up according to my tastes.

@ankith26 ankith26 requested a review from a team as a code owner June 2, 2024 15:58
@ankith26 ankith26 force-pushed the ankith26-math-fixes branch from a99527a to 3861d6d Compare June 2, 2024 15:59
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed clearer, nice

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks nicer I agree. I think lerp() has the same ambiguity between weight/value.

Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
@Starbuck5 Starbuck5 added the docs label Jun 2, 2024
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Starbuck5 Starbuck5 merged commit 8d122e3 into main Jun 2, 2024
39 checks passed
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Jun 2, 2024
@Starbuck5 Starbuck5 deleted the ankith26-math-fixes branch June 2, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants