Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SDL v1.2.10 checks in display.c #2928

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jun 15, 2024

Ran into this while working on SDL3 support, since they changed how version number getting works. Removing this is an easy win though, regardless.

@Starbuck5 Starbuck5 requested a review from a team as a code owner June 15, 2024 05:13
@Starbuck5 Starbuck5 marked this pull request as draft June 15, 2024 05:13
@Starbuck5 Starbuck5 force-pushed the remove-sdl-1-2-10-checks branch from b02b574 to ebb65f2 Compare June 15, 2024 05:20
@Starbuck5 Starbuck5 added sdl3 Code quality/robustness Code quality and resilience to changes labels Jun 15, 2024
@Starbuck5 Starbuck5 marked this pull request as ready for review June 15, 2024 05:29
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎈

@ankith26 ankith26 added this to the 2.5.1 milestone Jun 15, 2024
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 509d09b into pygame-community:main Jun 15, 2024
39 checks passed
@Starbuck5 Starbuck5 deleted the remove-sdl-1-2-10-checks branch June 18, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality/robustness Code quality and resilience to changes sdl3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants