Fix failing tests based on numpy v2 #2934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the ruff plugin suggested in NumPy 2.0 migration guide
Fixed all these issues by replacing the
alltrue
import with theall
import, now aliased tonp_all
to prevent name collision with python's builtinall
.Also fixed a few incorrect
sndarray
testcases and added a skip for a failingsurfarray
test (we will deal with it in the future)PS: the
numpy.all
function isnumpy v1
API, so now our tests can run on both numpy v1 and numpy v2