Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin all build dependencies #3015

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Pin all build dependencies #3015

merged 2 commits into from
Jul 22, 2024

Conversation

ankith26
Copy link
Member

Hopefully also fixes the latest windows builds hang issue

@ankith26 ankith26 requested a review from a team as a code owner July 22, 2024 08:06
@ankith26 ankith26 force-pushed the ankith26-pin-build branch from edfc7be to 1dd93ae Compare July 22, 2024 08:29
damusss
damusss approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor windows builds hanging themselves.

Matiiss
Matiiss approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure what uv is, but LGTM 👍
I mean, at least the config seems to make sense if it fixes stuff

oddbookworm
oddbookworm approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let’s get windows builds working again lol

@oddbookworm oddbookworm merged commit bc28809 into main Jul 22, 2024
22 checks passed
@oddbookworm oddbookworm deleted the ankith26-pin-build branch July 22, 2024 22:29
@oddbookworm oddbookworm added this to the 2.5.1 milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@Matiiss Matiiss Matiiss approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ankith26 @oddbookworm @Matiiss @damusss