Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this statement seems to be false, removing #3263

Merged
merged 1 commit into from
Dec 12, 2024
Merged

this statement seems to be false, removing #3263

merged 1 commit into from
Dec 12, 2024

Conversation

JovialKnoll
Copy link
Contributor

From a quick test fblits seems to work fine (not drawing anything) with an empty sequence. Unless I'm missing something I think this sentence can be removed.

@JovialKnoll JovialKnoll requested a review from a team as a code owner December 11, 2024 02:22
@JovialKnoll
Copy link
Contributor Author

from looking at history: I believe that this sentence was correct when fblits was first added, just doesn't seem to be anymore.

ankith26
ankith26 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I went over the fblits code and found nothing that should cause problems if a 0 length sequence is passed. Thanks for the PR 🎉

@ankith26 ankith26 requested a review from itzpr3d4t0r December 11, 2024 16:55
@ankith26
Copy link
Member

Requesting a review from the author of the fblits PR as their approval would be best to merge this PR

itzpr3d4t0r
itzpr3d4t0r approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny to see that turning out as a false statement, and even funnier me not remembering why i put that there!
Anyway it looks good to me, tested it with some random sequences and all worked well!

@yunline yunline added the docs label Dec 12, 2024
@Starbuck5 Starbuck5 merged commit 4bce011 into pygame-community:main Dec 12, 2024
2 checks passed
@Starbuck5 Starbuck5 added this to the 2.5.3 milestone Dec 12, 2024
@Starbuck5 Starbuck5 added the Surface pygame.Surface label Dec 12, 2024
@JovialKnoll JovialKnoll deleted the fblits_docs_fix branch December 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itzpr3d4t0r itzpr3d4t0r itzpr3d4t0r approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
docs Surface pygame.Surface
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@JovialKnoll @ankith26 @itzpr3d4t0r @yunline @Starbuck5