Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pygame.system.get_theme() (w/ sdl3) #3325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damusss
Copy link
Member

@damusss damusss commented Feb 2, 2025

I implemented fully what the title says, "fixing" half of #2760 (comment)

The codebase doesn't compile with sdl3 yet, so I'm not sure what kind of versionadded to put.

Depending on which PR gets in before compared to #3296 the other will have to be updated I guess.

@damusss damusss added New API This pull request may need extra debate as it adds a new class or function to pygame system pygame.system sdl3 labels Feb 2, 2025
@damusss damusss requested a review from a team as a code owner February 2, 2025 14:20
@Starbuck5
Copy link
Member

I don't think we're ready to have PRs like this yet. We don't have any branches, any releases targeting SDL3 right now.

We need to get stuff compiling on SDL3 first.

Let's say this merges, now everyone who reads the system docs sees a function that they have no way of using. And the description doesn't even say that this function is impossible to use, it only says it requires SDL3, which is not a statement most of our users will understand the implications of.

@damusss
Copy link
Member Author

damusss commented Feb 3, 2025

@Starbuck5 don't worry I'm aware that it will take a while for it to get in, i just followed roughly the indications ankith gave me not to have too many stagnant branches in my fork. btw what % are we in sdl3 porting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New API This pull request may need extra debate as it adds a new class or function to pygame sdl3 system pygame.system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants