bookofday plugin #23
Merged
bookofday plugin #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def book(self): | ||
| headers = {'Accept' : 'application/json'} | ||
| r = requests.get('https://icanhazdadjoke.com', headers=headers) | ||
| soup = BeautifulSoup(r.text, 'html.parser') |
There was a problem hiding this comment.
hum nice but you have to go to https://bookoftheday.org . If you want to contribute a dad joke plugin, just modify the name and command.
There was a problem hiding this comment.
ah my mistake. I was using that url while debugging. I just commited with the updated bookoftheday.org
|
see comment |
|
cool! merging, else, you tried the bot? |
Zernerus
pushed a commit
to Zernerus/honeybot
that referenced
this pull request
Jul 17, 2019
transfer-rumour plugin developed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brief description of changes
I added the bookofday plugin. This is my first open source contribution! Please let me know if I need to correct anything. The only thing I wasn't sure about was using beautifulsoup. Do I have to add that as a dependency somewhere?